Render generic identifiers as text inputs - #28
Open
masnwilliams wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
requested review from
akxue and
dcruzeneil2
and removed request for
dcruzeneil2
August 31, 2026 20:38
akxue
approved these changes
Aug 31, 2026
akxue
left a comment
There was a problem hiding this comment.
reviewed — looks good, straightforward fix
packages/managed-auth-react/src/session/state.ts:44— always-text for identifiers is the right default; the ref-sniffing was fragile (substring false positives) and native email/tel validation breaks combined fields. tradeoff noted: pure email/phone fields loseinputmodehints on mobile — worth revisiting smarter inference (ideally server-provided) once there's more signal- test coverage pins both removed inference branches (email-ref and phone-ref), and the fixture label reflects the real combined-field case
masnwilliams
force-pushed
the
hypeship/render-identifiers-as-text
branch
from
August 31, 2026 22:13
23f36af to
2280ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
identifierfields as text inputs regardless of their credential reftesting
bun testbun run buildbun run typecheckbun run format:checkrelease
Includes a patch changeset for
@onkernel/managed-auth-react.Note
Low Risk
Localized form rendering change in managed auth UI with no auth or data-handling impact; main effect is dropping strict browser validation on identifier inputs.
Overview
Canonical
identifierfields now always map to plaintextinputs in@onkernel/managed-auth-react, instead of inferringemailortelfrom the field ref (e.g.email,phone_number). Username/email/phone labels stay the same, but the browser no longer applies native email or telephone validation on those steps.Regression tests cover identifier refs named like email, username, and phone. A patch changeset is included for the package release.
Reviewed by Cursor Bugbot for commit 2280ac3. Bugbot is set up for automated code reviews on this repo. Configure here.